Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Coursework/sprint 1#1392
Open
asandagwala wants to merge 18 commits into
Open
Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Coursework/sprint 1#1392asandagwala wants to merge 18 commits into
asandagwala wants to merge 18 commits into
Conversation
…Module-Structuring-and-Testing-Data into coursework/sprint-1
asandagwala
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jun 29, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work exploring the stretch goals here.
I've left some comments for you to look at in the interpreting tasks
|
|
||
|
|
||
|
|
||
| // a) There are 2 function calls in this code. replaceAll() in line 4 and 5 and console.log() in line 10 |
There was a problem hiding this comment.
Good work finding these. Are there any more functions on line 4/5?
|
|
||
| // d) In line 4 the totalHours is calculated by subtracting the remainingMinutes from the totalMinutes and then dividing that answer by 60 | ||
|
|
||
| // e) It is a string representing the time movie time in hours, minutes and seconds |
There was a problem hiding this comment.
Do you think the variable name "result" is clear enough that this is what the string represents?
|
|
||
| // e) It is a string representing the time movie time in hours, minutes and seconds | ||
|
|
||
| // f) yes, because the variables for calculating the results use a formulas that will work with any number that is assigned to the movieLength variable No newline at end of file |
There was a problem hiding this comment.
It will run without errors, but are there any edge cases that give odd outputs?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is Sprint 1 of the Structuring and testing data module.
Note on Commit Contributors: >
You might notice two different contributor names in the commit history for this branch. I recently shared my laptop with someone else, and my initial commits were accidentally stamped with their Git profile details.
I have since corrected my global Git configuration, but the earlier commits still reflect the old metadata. All code on this branch was written entirely by me.